Housekeeping #73
Merged
Housekeeping #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shagedorn
commented
Aug 26, 2016
shagedorn
commented
- Sample app uses the dynamic framework
- Sample app now uses all categories (in the same order the categories are defined), unless they require capabilities – those are added, too, but commented out. This should allow us to easily test all categories locally.
- Add required configuration for Health and TencentWeibo requests in sample app
- Xcode housekeeping
added 5 commits
August 26, 2016 17:22
This requires the deployment target to deploy to iOS 8 and later
Disabled as it requires entitlements
| @(ISHPermissionCategorySocialFacebook), | ||
| @(ISHPermissionCategorySocialTwitter), | ||
| @(ISHPermissionCategorySocialSinaWeibo), | ||
| // TODO: alert cannot be presented |
Weak-linked via the framework
| @@ -38,6 +48,7 @@ - (NSString *)accountTypeIdentifier { | |||
| return ACAccountTypeIdentifierTencentWeibo; | |||
|
|
|||
| default: | |||
| NSAssert(NO, @"Invalid category: %@", @(self.permissionCategory)); | |||
There was a problem hiding this comment.
Shouldn't this follow the same pattern as above without a default?
There was a problem hiding this comment.
The code above probably raises a warning... we don't really want to list all ~15 categories, so I believe default is ok here. Plus, we usually don't care here if new categories are added.
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.