Skip to content

Commit

Permalink
Merge pull request #63 from iosphere/fix/iphonex
Browse files Browse the repository at this point in the history
Fixes an issue where dimming view would not be hidden on iPhone X
  • Loading branch information
felixLam authored Oct 20, 2017
2 parents 4d5cbc9 + e5c0bd9 commit da7a484
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ISHPullUp/ISHPullUpViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ - (BOOL)dimmingViewShouldBeHidden {

CGFloat maximumHeightOverMinimum = self.maximumBottomHeightCached - self.minimumBottomHeightCached;

if (!maximumHeightOverMinimum) {
if (maximumHeightOverMinimum <= 0) {
// if the view cannot be extended beyond minimum always hide dimming view
return YES;
}
Expand Down

0 comments on commit da7a484

Please sign in to comment.