Skip to content

Commit

Permalink
fix: persistedProfileMigrationToV11
Browse files Browse the repository at this point in the history
  • Loading branch information
cpl121 committed Oct 6, 2023
1 parent 0a541be commit 331cbe4
Showing 1 changed file with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,13 @@ function persistedProfileMigrationToV11(
const networkId = getNetworkIdFromOldNetworkType(existingProfile?.networkType)
if (networkId === NetworkId.Shimmer || networkId === NetworkId.Testnet) {
network = getDefaultPersistedNetwork(networkId)
network.coinType = COIN_TYPE[NetworkId.Shimmer]

This comment has been minimized.

Copy link
@begonaalvarezd

begonaalvarezd Oct 6, 2023

Member

we will never get to this line of code if all goes well, but wanted to mention that adding coinType Shimmer is incorrect for testnet

} else {
network.id = NetworkId.Custom
network = {
chains: [],
...(DEFAULT_NETWORK_METADATA[NetworkId.Iota] as NetworkMetadata),
}
}
network.coinType = COIN_TYPE[NetworkId.Shimmer]
existingProfile.network = structuredClone(network)
}

Expand Down

0 comments on commit 331cbe4

Please sign in to comment.