Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup TextHint #7165

Merged
merged 12 commits into from
Aug 1, 2023
Merged

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jul 12, 2023

Summary

Fixes #7162

Refactor component TextHint

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@VmMad VmMad added the type:refactor Refactor code label Jul 12, 2023
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job, just a few suggestions 🙏

packages/shared/components/TextHint.svelte Outdated Show resolved Hide resolved
packages/shared/components/TextHint.svelte Outdated Show resolved Hide resolved
@VmMad VmMad requested a review from evavirseda July 14, 2023 13:23
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🚀

@begonaalvarezd begonaalvarezd merged commit 7093159 into develop Aug 1, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/components/texthint branch August 1, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup TextHint
3 participants