Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Cleanup MarkdownBlock and markdown-renderers files #7218

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

evavirseda
Copy link
Collaborator

@evavirseda evavirseda commented Jul 14, 2023

Summary

Closes #7217

Changelog

- Cleanup MakdownBlock
- Cleanup LinkBlock
- Reorganize files

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@marc2332 marc2332 self-requested a review July 17, 2023 14:00
@evavirseda evavirseda requested a review from VmMad July 17, 2023 14:27
Copy link
Member

@VmMad VmMad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@begonaalvarezd begonaalvarezd merged commit 212f876 into develop Aug 1, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/cleanup-markdownBlock branch August 1, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cleanup MarkdownBlock
4 participants