Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix macOS build #7296

Closed
wants to merge 6 commits into from

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Aug 1, 2023

Summary

  • Installs Python 2 on macOS by downloading the PKG from python.org. This is necessary because actions/setup-python has removed support for Python 2 (python2.7 will be removed from the python-versions on June 19 actions/setup-python#672) but we still need it for the DMG builder script in electron-builder. This needs to be run right before building the DMG since Python 3 is necessary for node-gyp when building the bindings, but the Python 2 installation script will override it.
  • Remove NODE_GYP_FORCE_PYTHON
  • Use macOS 13 runner with latest stable Xcode
  • Set macOS deployment target to 10.13
  • Patch librocksdb-sys to support macOS 10.13 (see fix: support macOS 10.13 iota-sdk#195)

Changelog

- Drop support for macOS 10.12 (all models that support macOS 10.12 also support macOS 10.13)

Testing

CI passes

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@rajivshah3 rajivshah3 added os:mac Affects MacOS scope:ci Affects CI actions labels Aug 1, 2023
@rajivshah3
Copy link
Member Author

Closing in favor of #7303

@rajivshah3 rajivshah3 closed this Aug 3, 2023
@rajivshah3 rajivshah3 deleted the fix/macos-build branch August 3, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:mac Affects MacOS scope:ci Affects CI actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant