Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-python
has removed support for Python 2 (python2.7 will be removed from the python-versions on June 19 actions/setup-python#672) but we still need it for the DMG builder script inelectron-builder
. This needs to be run right before building the DMG since Python 3 is necessary fornode-gyp
when building the bindings, but the Python 2 installation script will override it.NODE_GYP_FORCE_PYTHON
librocksdb-sys
to support macOS 10.13 (see fix: support macOS 10.13 iota-sdk#195)Changelog
Testing
CI passes
Platforms
Instructions
...
Checklist