Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bls12_381_plus dependency more flexible again #1393

Merged
merged 10 commits into from
Sep 2, 2024

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Aug 13, 2024

Description of change

We had issues with bls12_381_plus dependency at version 0.8.16, therefore we pinned the version to 0.8.15. With 0.8.17 being released, we can allow this and following (SemVer compatible) versions.

Also fixed the cargo audit error by using a new release of iota-crypto.

A newer version of clippy had some warnings, that were addressed as well. These were mostly indentations in comments, but one test had a feature flag check, that does not seem to have been used in a Cargo.toml and/or a build.rs, removed the check.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix
  • Chore

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- making version range more flexible again
@wulfraem wulfraem added Chore Tedious, typically non-functional change Rust Related to the core Rust code. Becomes part of the Rust changelog. Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog labels Aug 13, 2024
@wulfraem wulfraem marked this pull request as ready for review August 15, 2024 06:26
@wulfraem wulfraem requested a review from a team as a code owner August 15, 2024 06:26
@wulfraem wulfraem merged commit b355b47 into main Sep 2, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants