Add support for "fauceting" test/example transaction via local active address #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `API_ENDPOINT` env variable for tests and examples - add `IOTA_IDENTITY_FUND_WITH_ACTIVE_ADDRESS` env variable to toggle funding via active address
wulfraem
added
Rust
UMR1352
reviewed
Dec 3, 2024
examples/utils/utils.rs
Outdated
| @@ -32,6 +32,7 @@ use secret_storage::Signer; | |||
| use serde_json::Value; | |||
|
|
|||
| pub const TEST_GAS_BUDGET: u64 = 50_000_000; | |||
| const DEFAULT_API_ENDPOINT: &str = "http://127.0.0.1:9000"; | |||
There was a problem hiding this comment.
We could use the iota_sdk exported constant IOTA_LOCAL_NETWORK_URL.
UMR1352
approved these changes
Dec 3, 2024
| @@ -50,6 +50,7 @@ static PACKAGE_ID: OnceCell<ObjectID> = OnceCell::const_new(); | |||
| static CLIENT: OnceCell<TestClient> = OnceCell::const_new(); | |||
| const SCRIPT_DIR: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/scripts/"); | |||
| const CACHED_PKG_ID: &str = "/tmp/iota_identity_pkg_id.txt"; | |||
| const DEFAULT_API_ENDPOINT: &str = "http://127.0.0.1:9000"; | |||
There was a problem hiding this comment.
Here as well let's just use iota_sdk::IOTA_LOCAL_NETWORK_URL.
itsyaasir
approved these changes
Dec 3, 2024
- now using `IOTA_LOCAL_NETWORK_URL` from `iota` create
UMR1352
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
PR adds support to fund transactions with active address of local IOTA client.
This allows to run tests to be run against environments with a faucet with stricter rules than on localnet or against an environment without a faucet.
Running tests/examples with env variable IOTA_IDENTITY_FUND_WITH_ACTIVE_ADDRESS
set totruewill use the local active address to send funds to new test/example accounts. For detail seeidentity_iota_core/README.md`.Another env variable to configure IOTA API endpoint has been added as well:
API_ENDPOINT. Defaults to local test environment if unset.Links to any relevant issues
#1469
Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Tested against local network and devnet.
Change checklist
Add an
xto the boxes that are relevant to your changes.