Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify serialization #472

Merged
merged 29 commits into from
Nov 8, 2023
Merged

Simplify serialization #472

merged 29 commits into from
Nov 8, 2023

Conversation

jonastheis
Copy link
Contributor

This PR simplifies and harmonizes serialization by addressing #284.

Depends on iotaledger/hive.go#596 and iotaledger/iota.go#590

Fixes #284

@jonastheis
Adjust retainer models to use stream package instead of marshalutil
1aed560
@jonastheis
Adjust utxoledger to use stream package instead marshalutil
72c83bf
@jonastheis
Merge remote-tracking branch 'origin/develop' into feat/simplify-seri…
d4668c2 
…alization
@jonastheis
Replace usage of marshalutil with stream package in network
5558829
@jonastheis
Adjust settings to new stream package
45e7996
@jonastheis
Adjust to changes of ads.Map and ads.Set
b8ff52b
@jonastheis
Adjust new stream package
5383f66
@jonastheis
Adjust accounts to new stream package and remove marshalutil usage
bb8d582
@jonastheis
Adjust debug API to changes of ads.Map and ads.Set
59e7583
@jonastheis
Adjust to renaming changes in iotaledger/hive.go@a5ebefe
6a5e28b
@jonastheis
Improve serialization of accounts: get rid of PositionedWriter and bi…
e242934 
…nary.Write usage and instead apply new stream package
@jonastheis
Merge remote-tracking branch 'origin/develop' into feat/simplify-seri…
a1867df 
…alization
@jonastheis
Remove PositionedWriter
cd0292b
@jonastheis
Adjust ValidatorPerformance to use stream package instead of manual b…
96763c3 
…inary.Read and deprecated PositionedWriter
@jonastheis
Make (de)serialization of BlockIssuerKeys consistent using new method…
0c643cf 
…s from iota.go
@jonastheis
Simplify typedKVstore usage
3865cc4
@jonastheis
Remove ioutils
6cdd097
@jonastheis
Adjust utxo ledger to use stream package instead of ioutils
d406b7b
@jonastheis
Remove dependency to github.com/orcaman/writerseeker
49a0be6
@jonastheis
Adjust utxo ledger to use stream package instead of manual binary.Read
7f5bd3d
@jonastheis
Merge remote-tracking branch 'origin/develop' into feat/simplify-seri…
9e59adb 
…alization
@jonastheis
Update go.mod to latest hive.go
9cfc673
@jonastheis jonastheis force-pushed the feat/simplify-serialization branch from 787e846 to 9cfc673 Compare November 6, 2023 06:44
@jonastheis jonastheis marked this pull request as ready for review November 6, 2023 06:47
@jonastheis jonastheis force-pushed the feat/simplify-serialization branch from 44b9e68 to 82f433e Compare November 6, 2023 08:00
alexsporn
alexsporn reviewed Nov 7, 2023
View reviewed changes
pkg/model/commitment.go Outdated Show resolved Hide resolved
@alexsporn alexsporn merged commit 9094100 into develop Nov 8, 2023
6 checks passed
@alexsporn alexsporn deleted the feat/simplify-serialization branch November 8, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsporn alexsporn alexsporn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonize serialization utils, methods on objects and more
2 participants
@jonastheis @alexsporn