listen error in wasm, madelisten async again

iotaledger · Sep 6, 2023 · 2db8aa4 · 2db8aa4
1 parent 25d9aa4
commit 2db8aa4
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 22 deletions.
diff --git a/bindings/nodejs/lib/bindings.ts b/bindings/nodejs/lib/bindings.ts
@@ -116,8 +116,8 @@ export {
     callSecretManagerMethodAsync,
     callUtilsMethod,
     callWalletMethodAsync,
-    destroyWallet,
     listenWalletAsync,
+    destroyWallet,
     getClientFromWallet,
     getSecretManagerFromWallet,
     listenMqtt,

diff --git a/bindings/nodejs/lib/wallet/wallet-method-handler.ts b/bindings/nodejs/lib/wallet/wallet-method-handler.ts
@@ -99,19 +99,17 @@ export class WalletMethodHandler {
      * @param eventTypes The wallet event types to listen for.
      * @param callback The callback function to call when an event is received.
      */
-    listen(
+    async listen(
         eventTypes: WalletEventType[],
         callback: (error: Error, event: Event) => void,
-    ): void {
-        try {
-            listenWalletAsync(eventTypes, callback, this.methodHandler).catch(
-                (error: any) => {
-                    throw errorHandle(error);
-                },
-            );
-        } catch (error: any) {
+    ): Promise<void> {
+        return listenWalletAsync(
+            eventTypes,
+            callback,
+            this.methodHandler,
+        ).catch((error: any) => {
             throw errorHandle(error);
-        }
+        });
     }
 
     /**
@@ -131,7 +129,7 @@ export class WalletMethodHandler {
      */
     getSecretManager(): SecretManager {
         try {
-            const result = getSecretManagerFromWallet(this.methodHandler);
+            let result = getSecretManagerFromWallet(this.methodHandler);
             return new SecretManager(result);
         } catch (error: any) {
             throw errorHandle(error);

diff --git a/bindings/nodejs/lib/wallet/wallet.ts b/bindings/nodejs/lib/wallet/wallet.ts
@@ -199,11 +199,11 @@ export class Wallet {
     /**
      * Listen to wallet events with a callback. An empty array will listen to all possible events.
      */
-    listen(
+    async listen(
         eventTypes: WalletEventType[],
         callback: (error: Error, event: Event) => void,
-    ): void {
-        this.methodHandler.listen(eventTypes, callback);
+    ): Promise<void> {
+        return this.methodHandler.listen(eventTypes, callback);
     }
 
     /**

diff --git a/bindings/wasm/src/wallet.rs b/bindings/wasm/src/wallet.rs
@@ -148,13 +148,16 @@ pub async fn listen_wallet(
     // Spawn on the same thread a continuous loop to check the channel
     wasm_bindgen_futures::spawn_local(async move {
         while let Some(wallet_event) = rx.recv().await {
-            callback
-                .call1(
-                    &JsValue::NULL,
-                    &JsValue::from(serde_json::to_string(&wallet_event).unwrap()),
-                )
-                // Safe to unwrap, our callback has no return
-                .unwrap();
+            let res = callback.call2(
+                &JsValue::NULL,
+                &JsValue::UNDEFINED,
+                &JsValue::from(serde_json::to_string(&wallet_event).unwrap()),
+            );
+            // Call callback again with the error this time, to prevent wasm crashing.
+            // This does mean the callback is called a second time instead of once.
+            if let Err(e) = res {
+                callback.call2(&JsValue::NULL, &e, &JsValue::UNDEFINED).unwrap();
+            }
         }
         // No more links to the unbounded_channel, exit loop
     });