Fix needs_blind_signing() for non Ed25519 addresses (#1710)

iotaledger · Nov 29, 2023 · 38e4f97 · 38e4f97
1 parent 24f1057
commit 38e4f97
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/sdk/CHANGELOG.md b/sdk/CHANGELOG.md
@@ -29,6 +29,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Display of `WalletError::InsufficientFunds`;
 
+### Fixed
+
+- `needs_blind_signing()` for non Ed25519 addresses;
+
 ## 1.1.2 - 2023-10-26
 
 ### Added

diff --git a/sdk/src/client/secret/ledger_nano.rs b/sdk/src/client/secret/ledger_nano.rs
@@ -426,11 +426,9 @@ impl SecretManagerConfig for LedgerSecretManager {
 pub fn needs_blind_signing(prepared_transaction: &PreparedTransactionData, buffer_size: usize) -> bool {
     let TransactionEssence::Regular(essence) = &prepared_transaction.essence;
 
-    if !essence
-        .outputs()
-        .iter()
-        .all(|output| matches!(output, Output::Basic(o) if o.simple_deposit_address().is_some()))
-    {
+    if !essence.outputs().iter().all(
+        |output| matches!(output, Output::Basic(o) if o.simple_deposit_address().is_some() && o.address().is_ed25519()),
+    ) {
         return true;
     }