Skip to content

Commit

Permalink
added protocol params to sign
Browse files Browse the repository at this point in the history
  • Loading branch information
Brord van Wierst committed Dec 11, 2023
1 parent 78e022b commit 6bacf19
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions bindings/python/iota_sdk/secret_manager/secret_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from iota_sdk.external import create_secret_manager, call_secret_manager_method
from iota_sdk.types.block.signed_block import SignedBlock, UnsignedBlock
from iota_sdk.types.common import HexStr
from iota_sdk.types.node_info import ProtocolParameters
from iota_sdk.types.signature import Ed25519Signature, Bip44
from iota_sdk.types.transaction_data import PreparedTransactionData
from iota_sdk.types.payload import SignedTransactionPayload
Expand Down Expand Up @@ -268,14 +269,16 @@ def sign_secp256k1_ecdsa(self, message: HexStr, chain: Bip44):
})

def sign_transaction(
self, prepared_transaction_data: PreparedTransactionData) -> SignedTransactionPayload:
self, prepared_transaction_data: PreparedTransactionData, protocol_parameters: ProtocolParameters) -> SignedTransactionPayload:
"""Sign a transaction.
Args:
prepare_transaction_data: The prepared transaction data that needs to be signed.
protocol_parameters: The protocol parameters used in creating the signed transaction.
"""
return SignedTransactionPayload.from_dict(self._call_method('signTransaction', {
'preparedTransactionData': prepared_transaction_data.to_dict()
'preparedTransactionData': prepared_transaction_data.to_dict(),
'protocolParameters': protocol_parameters
}))

def sign_block(
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/iota_sdk/types/balance.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class BaseCoinBalance:
@json
@dataclass
class RequiredStorageDeposit:
"""Required storage deposit for the outputs in the account.
"""Required storage deposit for the outputs in the wallet.
Attributes:
basic: The required amount for basic outputs.
Expand Down

0 comments on commit 6bacf19

Please sign in to comment.