Improve binary_response

iotaledger · Dec 6, 2023 · 9f38c62 · 9f38c62
1 parent 3c46a64
commit 9f38c62
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/sdk/tests/types/api/core.rs b/sdk/tests/types/api/core.rs
@@ -10,6 +10,7 @@ use iota_sdk::types::{
 };
 use packable::{
     error::{UnexpectedEOF, UnpackError},
+    unpacker::SliceUnpacker,
     Packable, PackableExt,
 };
 use serde::Deserialize;
@@ -28,8 +29,12 @@ fn binary_response<T: PackableExt>(
 ) -> Result<T, UnpackError<<T as Packable>::UnpackError, UnexpectedEOF>> {
     let file = std::fs::read_to_string(&format!("./tests/types/api/fixtures/{path}")).unwrap();
     let bytes = hex::decode(file).unwrap();
-    T::unpack_verified(bytes, visitor)
-    // TODO check there is no bytes left
+    let mut unpacker = SliceUnpacker::new(bytes.as_slice());
+    let res = T::unpack::<_, true>(&mut unpacker, visitor);
+
+    assert!(u8::unpack::<_, true>(&mut unpacker, &()).is_err());
+
+    res
 }
 
 #[test]

diff --git a/sdk/tests/types/api/fixtures/get-commitment-response-binary-example b/sdk/tests/types/api/fixtures/get-commitment-response-binary-example
@@ -1 +1 @@
-070000000a1a0000977c626276b19ef8b3c445709f2f0f2ccc4abb98d97617f421f240c0d1ee066d4306e67a0321889ef8ec89b7eff1378049e058f0fa87a78c2452ae72631a5a99d913d1cbb3525b8faa1800e28dfcb28154bcba10154c39ef87ceda793cb44f58ae1549c88ea13fe4a9695bb6f0aba6cb756522209e5066a96039ae12b398b975693bdc21e222997c86ff9bfc5844f0372d58ff6fa510688e53c181bbdf4db41f9b627540a70e5751c026e543b2e8ab2eb06099daa1d1e5df47778f7787faab45cdf12fe3a80000000300d85e5b1590d898d1e0cdebb2e3b5337c8b76270142663d78811683ba47c17c989ad7a8f0ff2c6438bf435786d4a5b0125a5caf7367061b49a739389d5ebea234c0466c86f88a3f8add03bff04c2e34b214683f2f6983641e1d1185da7e2c3e0200d9922819a39e94ddf3907f4b9c8df93f39f026244fcb609205b9a879022599f218be2536d8b7b8547faa3dbdfe98339ebe9e2b2417a8a03eee02b2a8312b9e026dd0a33261a58a240cd0a1b06cdf1775d98d316f162d3eec402f4bf08bea2a0700f9d9656a60049083eef61487632187b351294c1fa23d118060d813db6d03e8b6ca8180d435708e826bc2042ccd667babb59c5cc461ff29dba966359fcd6fc511cdfdf10d6576f36ac2a6e5cb691e13968c13947ffbd9239939d3802b2fbe0f06
+0312000000075b05e0a8fd4b9c7e7bc165b62c48945292f7d76d23f76525f886c416dc0e364089b57c32ddb8c614ed1d2c844401d2a5325b4d153c7f94464bbda3a8d14289b203f96759000000000000009000000000000000