Rename to versionSignalingParameters

iotaledger · Nov 23, 2023 · cd11e72 · cd11e72
1 parent b23d0e2
commit cd11e72
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/bindings/nodejs/lib/types/models/info/node-info-protocol.ts b/bindings/nodejs/lib/types/models/info/node-info-protocol.ts
@@ -102,7 +102,7 @@ export interface ProtocolParameters {
     /**
      * The parameters used by signaling protocol parameters upgrade.
      */
-    versionSignaling: VersionSignalingParameters;
+    versionSignalingParameters: VersionSignalingParameters;
     /**
      * Rewards Parameters defines the parameters that are used to calculate Mana rewards.
      */

diff --git a/bindings/python/iota_sdk/types/node_info.py b/bindings/python/iota_sdk/types/node_info.py
@@ -149,7 +149,7 @@ class CongestionControlParameters:
 
 @json
 @dataclass
-class VersionSignaling:
+class versionSignalingParameters:
     """Version Signaling defines the parameters used by signaling protocol parameters upgrade.
 
     Attributes:
@@ -271,7 +271,7 @@ class ProtocolParameters:
         encoder=str
     ))
     congestion_control_parameters: CongestionControlParameters
-    version_signaling: VersionSignaling
+    version_signaling_parameters: versionSignalingParameters
     rewards_parameters: RewardsParameters
 
 

diff --git a/sdk/src/client/secret/ledger_nano.rs b/sdk/src/client/secret/ledger_nano.rs
@@ -145,7 +145,6 @@ impl SecretManage for LedgerSecretManager {
     ) -> Result<Vec<ed25519::PublicKey>, Self::Error> {
         // need an update on the ledger C lib
         todo!();
-        //
         // let options = options.into().unwrap_or_default();
         // let bip32_account = account_index.harden().into();
 

diff --git a/sdk/src/client/stronghold/secret.rs b/sdk/src/client/stronghold/secret.rs
@@ -581,10 +581,12 @@ mod tests {
         stronghold_adapter.clear_key().await;
 
         // Address generation returns an error when the key is cleared.
-        assert!(stronghold_adapter
-            .generate_ed25519_addresses(IOTA_COIN_TYPE, 0, 0..1, None,)
-            .await
-            .is_err());
+        assert!(
+            stronghold_adapter
+                .generate_ed25519_addresses(IOTA_COIN_TYPE, 0, 0..1, None,)
+                .await
+                .is_err()
+        );
 
         stronghold_adapter.set_password("drowssap".to_owned()).await.unwrap();
 

diff --git a/sdk/src/types/block/protocol.rs b/sdk/src/types/block/protocol.rs
@@ -82,7 +82,7 @@ pub struct ProtocolParameters {
     /// Parameters used to calculate the Reference Mana Cost (RMC).
     pub(crate) congestion_control_parameters: CongestionControlParameters,
     /// Defines the parameters used to signal a protocol parameters upgrade.
-    pub(crate) version_signaling: VersionSignalingParameters,
+    pub(crate) version_signaling_parameters: VersionSignalingParameters,
     /// Defines the parameters used for reward calculation.
     pub(crate) rewards_parameters: RewardsParameters,
     /// Defines the target size of the committee. If there's fewer candidates the actual committee size could be

diff --git a/sdk/tests/types/protocol.rs b/sdk/tests/types/protocol.rs
@@ -64,7 +64,7 @@
 //           "maxBufferSize":1000,
 //           "maxValidationBufferSize":100
 //         },
-//         "versionSignaling":{
+//         "versionSignalingParameters":{
 //           "windowSize":7,
 //           "windowTargetRatio":5,
 //           "activationOffset":7