Address some TODOs

iotaledger · Nov 24, 2023 · edf7deb · edf7deb
1 parent b23d0e2
commit edf7deb
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/.github/actions/private-tangle/setup/action.yml b/.github/actions/private-tangle/setup/action.yml
@@ -38,7 +38,6 @@ runs:
     - name: Wait for tangle to start
       shell: bash
       run: wget -qO- https://raw.githubusercontent.com/eficode/wait-for/v2.2.4/wait-for | sh -s -- -t 120 http://localhost:8050/health -- echo "Tangle is up"
-    # TODO enable, maybe need another URL
-    # - name: Wait for faucet to start
-    # shell: bash
-    # run: wget -qO- https://raw.githubusercontent.com/eficode/wait-for/v2.2.4/wait-for | sh -s -- -t 120 http://localhost:8081/api/info -- echo "Faucet is up"
+    - name: Wait for faucet to start
+      shell: bash
+      run: wget -qO- https://raw.githubusercontent.com/eficode/wait-for/v2.2.4/wait-for | sh -s -- -t 120 http://localhost:8088/health -- echo "Faucet is up"
diff --git a/sdk/src/client/secret/ledger_nano.rs b/sdk/src/client/secret/ledger_nano.rs
@@ -145,7 +145,6 @@ impl SecretManage for LedgerSecretManager {
     ) -> Result<Vec<ed25519::PublicKey>, Self::Error> {
         // need an update on the ledger C lib
         todo!();
-        //
         // let options = options.into().unwrap_or_default();
         // let bip32_account = account_index.harden().into();
 

diff --git a/sdk/src/client/stronghold/secret.rs b/sdk/src/client/stronghold/secret.rs
@@ -581,10 +581,12 @@ mod tests {
         stronghold_adapter.clear_key().await;
 
         // Address generation returns an error when the key is cleared.
-        assert!(stronghold_adapter
-            .generate_ed25519_addresses(IOTA_COIN_TYPE, 0, 0..1, None,)
-            .await
-            .is_err());
+        assert!(
+            stronghold_adapter
+                .generate_ed25519_addresses(IOTA_COIN_TYPE, 0, 0..1, None,)
+                .await
+                .is_err()
+        );
 
         stronghold_adapter.set_password("drowssap".to_owned()).await.unwrap();
 

diff --git a/sdk/src/types/block/rand/output/mod.rs b/sdk/src/types/block/rand/output/mod.rs
@@ -43,7 +43,6 @@ pub fn rand_output_id() -> OutputId {
 
 /// Generates a random [`BasicOutput`](BasicOutput).
 pub fn rand_basic_output(token_supply: u64) -> BasicOutput {
-    // TODO: Add `NativeTokens`
     BasicOutput::build_with_amount(rand_number_range(0..token_supply))
         .with_features(rand_allowed_features(BasicOutput::ALLOWED_FEATURES))
         .add_unlock_condition(rand_address_unlock_condition())

diff --git a/sdk/src/wallet/core/operations/client.rs b/sdk/src/wallet/core/operations/client.rs
@@ -63,8 +63,7 @@ where
             // Update the protocol of the network_info to not have the default data, which can be wrong
             // Ignore errors, because there might be no node at all and then it should still not error
             if let Ok(info) = self.client.get_info().await {
-                // TODO
-                // network_info.protocol_parameters = info.node_info.protocol;
+                network_info.protocol_parameters = info.node_info.latest_protocol_parameters().parameters.clone();
             }
             *self.client.network_info.write().await = network_info;