Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings ProtocolParameters tests #1338

Closed
2 tasks done
kwek20 opened this issue Sep 27, 2023 · 1 comment · Fixed by #1508
Closed
2 tasks done

Bindings ProtocolParameters tests #1338

kwek20 opened this issue Sep 27, 2023 · 1 comment · Fixed by #1508
Assignees
@Alex6323
Labels
b-nodejs Bindings - Nodejs b-python Bindings - Python m-types Module - Types t-test Task - Test
Milestone
v2.0.0 (Q4 2023)

Comments

@kwek20
Copy link
Contributor

kwek20 commented Sep 27, 2023 •
edited by thibault-martinez
Loading

Description

Similar to https://github.com/iotaledger/iota-sdk/blob/2.0/sdk/tests/types/protocol.rs

As requested here: #1276 (review)

Motivation

We want to validate that the node sends us the protocol parameters we expect on all bindings

Requirements

  • Nodejs
  • Python

Open questions

  • What is the purpose of this test in bindings after the protocol parameters are finalized?
@kwek20 kwek20 mentioned this issue Sep 27, 2023
Merged
@kwek20 kwek20 changed the title Node ProtocolParameters test BindingsProtocolParameters tests Sep 27, 2023
@kwek20 kwek20 changed the title BindingsProtocolParameters tests Bindings ProtocolParameters tests Sep 27, 2023
@thibault-martinez thibault-martinez added b-nodejs Bindings - Nodejs b-python Bindings - Python m-types Module - Types t-test Task - Test labels Sep 29, 2023
@thibault-martinez thibault-martinez added this to the v2.0.0 milestone Sep 29, 2023
@thibault-martinez thibault-martinez assigned kwek20 and Alex6323 and unassigned kwek20 Oct 16, 2023
@Alex6323 Alex6323 mentioned this issue Oct 25, 2023
Merged
@Alex6323 Alex6323 linked a pull request Oct 27, 2023 that will close this issue
Bindings: Add ProtocolParameters tests #1508
Merged
@thibault-martinez
Copy link
Member

Closed by #1508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex6323 Alex6323

Labels
b-nodejs Bindings - Nodejs b-python Bindings - Python m-types Module - Types t-test Task - Test
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q4 2023)
Development

Successfully merging a pull request may close this issue.

Bindings: Add ProtocolParameters tests Alex6323/iota-sdk
3 participants
@kwek20 @thibault-martinez @Alex6323