Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/python: Update NodeInfo #1276

Merged
merged 15 commits into from
Sep 27, 2023
Merged

feat/python: Update NodeInfo #1276

merged 15 commits into from
Sep 27, 2023

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Sep 20, 2023

Description of change

Updates NodeInfo and subtypes

Links to any relevant issues

fixes #1017
fixes #1135

DaughterOfMars
DaughterOfMars reviewed Sep 20, 2023
View reviewed changes
Copy link

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add a test that does the same thing as the test in protocol.rs

@kwek20
Copy link
Contributor Author

kwek20 commented Sep 20, 2023

Probably should add a test that does the same thing as the test in protocol.rs

I dont think thats beneficial, seems to just make a random protocol with random fields in rust.
We could use a nodeinfo test i guess, but out of scope

@DaughterOfMars
Copy link

It's to verify the structure against the TIP data...

@kwek20
Copy link
Contributor Author

kwek20 commented Sep 21, 2023

It's to verify the structure against the TIP data...

Yea i understand, but as we pass rust ProtocolParams, we get that for free right?

This was linked to issues Sep 21, 2023
Update InfoResponse - python #1017
Closed
Adapt ProtocolParameters - Python #1135
Closed
Thoralf-M
Thoralf-M previously approved these changes Sep 25, 2023
View reviewed changes
@DaughterOfMars
Copy link

It's to verify the structure against the TIP data...

Yea i understand, but as we pass rust ProtocolParams, we get that for free right?

No, this is an independent structure. We have no tests to validate it's structure.

@thibault-martinez
Copy link
Member

It's to verify the structure against the TIP data...

Yea i understand, but as we pass rust ProtocolParams, we get that for free right?

No, this is an independent structure. We have no tests to validate it's structure.

I agree

@kwek20 kwek20 mentioned this pull request Sep 27, 2023
Closed
2 tasks
@kwek20
Copy link
Contributor Author

kwek20 commented Sep 27, 2023

It's to verify the structure against the TIP data...

Yea i understand, but as we pass rust ProtocolParams, we get that for free right?

No, this is an independent structure. We have no tests to validate it's structure.

Made an issue #1338

@thibault-martinez thibault-martinez merged commit cb0659f into iotaledger:2.0 Sep 27, 2023
3 checks passed
This was referenced Sep 27, 2023
Closed
Closed
@Alex6323 Alex6323 mentioned this pull request Oct 5, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt ProtocolParameters - Python Update InfoResponse - python
5 participants
@kwek20 @DaughterOfMars @thibault-martinez @Alex6323 @Thoralf-M