Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OutputIdProof to /api/core/v3/outputs/{outputId} #1686

Closed
Thoralf-M opened this issue Nov 27, 2023 · 1 comment · Fixed by #1763
Closed

Add OutputIdProof to /api/core/v3/outputs/{outputId} #1686

Thoralf-M opened this issue Nov 27, 2023 · 1 comment · Fixed by #1763
Assignees
Labels
m-types Module - Types

Comments

@Thoralf-M
Copy link
Member

https://editor.swagger.io/?url=https://raw.githubusercontent.com/iotaledger/tips/tip48/tips/TIP-0048/openapi3-core.yaml

Started with this, but then wasn't sure about the type for output_commitment_proof

/// The proof of the output identifier.
#[derive(Clone, Debug, Eq, PartialEq, Hash)]
#[cfg_attr(
    feature = "serde",
    derive(serde::Serialize, serde::Deserialize),
    serde(rename_all = "camelCase")
)]
pub struct OutputIdProof {
    /// The slot index of the output.
    slot: SlotIndex,
    /// The index of the output.
    output_index: u16,
    /// The commitment of the transaction that created the output.
    transaction_commitment: SlotCommitmentId,
    /// The proof of the output commitment.
    output_commitment_proof: todo!("what type here?"),
}

Open questions (optional)

Is output_commitment_proof really a string? https://github.com/iotaledger/tips/pull/153/files#r1405938087

@thibault-martinez
Copy link
Member

Closed by #1763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-types Module - Types
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants