Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /api/core/v3/outputs/{outputId}/full route #1733

Merged
merged 10 commits into from
Dec 11, 2023

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Dec 4, 2023

Description of change

Add /api/core/v3/outputs/{outputId}/full route

Links to any relevant issues

Closes #1688

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Running the added example

Alex6323
Alex6323 previously approved these changes Dec 6, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Dec 6, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Dec 6, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common Feature Sets failing

@Thoralf-M
Copy link
Member Author

Thoralf-M commented Dec 6, 2023

Common Feature Sets failing

There is a small problem that asks for changes in 55 files :trollface:
Thoralf-M/iota-sdk@outputs-full-route...Thoralf-M:iota-sdk:small-change
In this PR here I only modified OutputMetadata, but we also had a OutputMetadataResponse which is now redundant
And then is the question if we want to store the OutputIdProof everywhere or if we say we don't need it

Alex6323
Alex6323 previously approved these changes Dec 8, 2023
@thibault-martinez
Copy link
Member

Common Feature Sets failing

There is a small problem that asks for changes in 55 files :trollface: Thoralf-M/[email protected]:iota-sdk:small-change In this PR here I only modified OutputMetadata, but we also had a OutputMetadataResponse which is now redundant And then is the question if we want to store the OutputIdProof everywhere or if we say we don't need it

I don't understand your answer. This is unrelated to the CI failing?

@Thoralf-M
Copy link
Member Author

@thibault-martinez CI is failing because I imported an API type to types module which is not no_std compatible, so I moved the OutputWithMetadata out of the types and replaced the OutputWithMetadataResponse
And because OutputWithMetadata is used all over the place, it all needed to be updated

@thibault-martinez thibault-martinez merged commit 82f6556 into iotaledger:2.0 Dec 11, 2023
30 of 36 checks passed
@Thoralf-M Thoralf-M deleted the outputs-full-route branch December 11, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /api/core/v3/outputs/{outputId}/full route
4 participants