Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate alternative to dialoguer #437

Closed
Alex6323 opened this issue May 11, 2023 · 2 comments · Fixed by #1238
Closed

Investigate alternative to dialoguer #437

Alex6323 opened this issue May 11, 2023 · 2 comments · Fixed by #1238
Assignees
@Alex6323
Labels
i-dependencies Infra - Dependencies m-cli Module - CLI t-investigate Task - Investigation
Milestone
v1.1.0

Comments

@Alex6323
Copy link
Contributor

Description

I think we should look if there's something better out there. I feel like RustyLine could be worth a look.

Motivation

There are few things that aren't so great about it:

  • CTRL-C during a multiple-choice select kills the cursor
  • weird behavior when pasting a mnemonic
  • no general CTRL-L
  • limited cursor movement on text inputs

Open questions (optional)

What disadvantage do the alternative have over dialoguer?

Are you planning to do it yourself in a pull request?

Sure.
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk May 11, 2023
@thibault-martinez thibault-martinez added this to the v1.1.0 milestone May 12, 2023
@thibault-martinez thibault-martinez added m-cli Module - CLI dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx labels May 15, 2023
@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Sep 11, 2023
@thibault-martinez thibault-martinez added i-dependencies Infra - Dependencies t-investigate Task - Investigation and removed dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx labels Sep 13, 2023
@Alex6323 Alex6323 moved this from Sprint Backlog to In Progress in iota-sdk Sep 14, 2023
@Alex6323
Copy link
Contributor Author

a small poc project showed that rustyline does a good job

This was referenced Sep 15, 2023
Closed
Merged
@Alex6323 Alex6323 moved this from In Progress to In Review in iota-sdk Sep 18, 2023
@thibault-martinez thibault-martinez linked a pull request Sep 20, 2023 that will close this issue
feat(cli): rustyline instead of dialoguer #1238
Merged
@thibault-martinez
Copy link
Member

Closed by #1238

@github-project-automation github-project-automation bot moved this from In Review to Done in iota-sdk Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex6323 Alex6323

Labels
i-dependencies Infra - Dependencies m-cli Module - CLI t-investigate Task - Investigation
Projects
iota-sdk
Status: Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat(cli): rustyline instead of dialoguer Alex6323/iota-sdk
2 participants
@thibault-martinez @Alex6323