Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): rustyline instead of dialoguer #1238

Merged
merged 12 commits into from
Sep 20, 2023
Merged

feat(cli): rustyline instead of dialoguer #1238

merged 12 commits into from
Sep 20, 2023

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Sep 15, 2023 •
edited
Loading

Description of change

Replace dialoguer with rustyline for the interactive account management in the CLI wallet. This makes the wallet overall more convenient to use.

With this PR the following is now supported:

  • Improved TAB completion for commands (prints a list of matching commands on double TAB)
  • CTRL-L to clear the terminal (no need to type c or clear anymore)
  • HOME/END/... navigation
  • Auto-complete for commands from the history
  • Proper handling of CTRL-C (or any other interrupt)

Links to any relevant issues

Closes #437
Closes #260

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running the CLI wallet.

@Alex6323 Alex6323 marked this pull request as ready for review September 18, 2023 07:28
Thoralf-M
Thoralf-M reviewed Sep 18, 2023
View reviewed changes
cli/Cargo.toml Outdated Show resolved Hide resolved
thibault-martinez
thibault-martinez requested changes Sep 18, 2023
View reviewed changes
cli/CHANGELOG.md Show resolved Hide resolved
cli/Cargo.toml Outdated Show resolved Hide resolved
cli/src/account_completion.rs Outdated Show resolved Hide resolved
cli/src/account_history.rs Outdated Show resolved Hide resolved
Thoralf-M
Thoralf-M previously approved these changes Sep 18, 2023
View reviewed changes
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars reviewed Sep 18, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez linked an issue Sep 18, 2023 that may be closed by this pull request
CLI: handle CTRL-L to clear the terminal page #260
Closed
DaughterOfMars
DaughterOfMars reviewed Sep 19, 2023
View reviewed changes
cli/src/account.rs Outdated Show resolved Hide resolved
DaughterOfMars
DaughterOfMars previously approved these changes Sep 19, 2023
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Sep 19, 2023
View reviewed changes
@thibault-martinez thibault-martinez merged commit b9dd984 into iotaledger:1.1 Sep 20, 2023
23 checks passed
@thibault-martinez thibault-martinez linked an issue Sep 20, 2023 that may be closed by this pull request
Investigate alternative to dialoguer #437
Closed
This was referenced Sep 20, 2023
Closed
Closed
@Alex6323 Alex6323 deleted the feat/cli/rustyline branch September 20, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate alternative to dialoguer CLI: handle CTRL-L to clear the terminal page
4 participants
@Alex6323 @thibault-martinez @DaughterOfMars @Thoralf-M