Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace our Hrp with the bech32 crate one #472

Closed
thibault-martinez opened this issue May 22, 2023 · 3 comments · Fixed by #1413
Closed

Replace our Hrp with the bech32 crate one #472

thibault-martinez opened this issue May 22, 2023 · 3 comments · Fixed by #1413
Assignees
@Alex6323
Labels
m-types Module - Types t-refactor Task - Refactor
Milestone
v2.0.0 (Q4 2023)

Comments

@thibault-martinez
Copy link
Member

thibault-martinez commented May 22, 2023 •
edited by Thoralf-M
Loading

Waiting for a new release of the bech32 crate with this change rust-bitcoin/rust-bech32#99
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk May 22, 2023
@thibault-martinez thibault-martinez added this to the v1.0.0 milestone May 26, 2023
@thibault-martinez thibault-martinez modified the milestones: v1.0.0, v2.0.0 Jun 14, 2023
@thibault-martinez thibault-martinez modified the milestones: 2.0 TIPs, v2.0.0 Sep 6, 2023
@thibault-martinez thibault-martinez added m-types Module - Types t-refactor Task - Refactor labels Sep 13, 2023
@tcharding
Copy link

Its out now https://docs.rs/bech32/0.10.0-alpha/bech32/primitives/hrp/struct.Hrp.html

Hope you find it useful.

@thibault-martinez
Copy link
Member Author

Its out now https://docs.rs/bech32/0.10.0-alpha/bech32/primitives/hrp/struct.Hrp.html

Hope you find it useful.

Thanks, will try it in the next few days.

@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Oct 2, 2023
@Alex6323 Alex6323 moved this from Sprint Backlog to In Progress in iota-sdk Oct 10, 2023
@Alex6323 Alex6323 mentioned this issue Oct 10, 2023
Merged
@Alex6323 Alex6323 moved this from In Progress to In Review in iota-sdk Oct 10, 2023
@Alex6323 Alex6323 linked a pull request Oct 11, 2023 that will close this issue
refactor(types): Hrp wraps bech32::Hrp #1413
Merged
@thibault-martinez
Copy link
Member Author

Closed by #1413

@github-project-automation github-project-automation bot moved this from In Review to Done in iota-sdk Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alex6323 Alex6323

Labels
m-types Module - Types t-refactor Task - Refactor
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q4 2023)
Development

Successfully merging a pull request may close this issue.

refactor(types): Hrp wraps bech32::Hrp Alex6323/iota-sdk
3 participants
@thibault-martinez @tcharding @Alex6323