refactor(types): Hrp wraps bech32::Hrp
#1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex6323
changed the title
Hrp wraps bech32::Hrp
DaughterOfMars
approved these changes
Oct 10, 2023
kwek20
reviewed
Oct 16, 2023
|
hrp_from_str test fails :( |
DaughterOfMars
previously approved these changes
Oct 16, 2023
thibault-martinez
previously approved these changes
Oct 17, 2023
DaughterOfMars
previously approved these changes
Oct 17, 2023
thibault-martinez
dismissed stale reviews from DaughterOfMars and themself
via
b56ee5f
thibault-martinez
approved these changes
Oct 17, 2023
DaughterOfMars
approved these changes
Oct 17, 2023
kwek20
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Turns
Hrptype into a wrapper ofbech32::Hrp. This way we can use their parsing logic, but still implement foreign traits on it.Links to any relevant issues
Closes #472
Type of change