New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update info response and related structs #1028

Merged

DaughterOfMars merged 36 commits into 2.0 from feat/info-response

Aug 25, 2023

DaughterOfMars commented Aug 16, 2023

Description of change

Updates ProtocolParameters and InfoResponse to match the core API spec.

Links to any relevant issues

Closes #1015


          Update info response and related structs

8b975e4

DaughterOfMars requested review from thibault-martinez, qrayven, abdulmth and Thoralf-M

August 16, 2023 15:41

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/error.rs Outdated Show resolved Hide resolved

Alex Coats added 3 commits

August 16, 2023 12:34


          display

c4aac92


          fix wasm, no_std and test

7f229d8


          fix one more test

ec0a0f9

thibault-martinez reviewed

View reviewed changes

sdk/src/types/block/core.rs Show resolved Hide resolved

thibault-martinez reviewed

View reviewed changes

sdk/tests/types/block_id.rs Outdated Show resolved Hide resolved

Alexandcoats added 3 commits

August 17, 2023 09:27


          Merge branch '2.0' into feat/info-response

89b3616


          Merge branch '2.0' into feat/info-response

3f11a3b


          Merge branch '2.0' into feat/info-response

d729d29

thibault-martinez reviewed

View reviewed changes

sdk/src/client/node_manager/syncing.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/api/core/response.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/tests/client/client_builder.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/protocol.rs Outdated Show resolved Hide resolved

Alex Coats added 2 commits

August 21, 2023 10:15


          Implement mapped params, epoch index, helpers

7c2dec2


          fix tests, wasm

c342573

Thoralf-M reviewed

View reviewed changes

sdk/src/client/api/high_level.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/protocol.rs Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/slot/epoch.rs Outdated Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/slot/epoch.rs Outdated Show resolved Hide resolved

Alexandcoats and others added 4 commits

August 22, 2023 08:03


          copy/paste oopsie

f8010d1

Co-authored-by: Thoralf-M <[email protected]>


          Merge branch '2.0' into feat/info-response

ab9e87e


          tangle time

4a3c845


          suggestions

a96ad21

Thoralf-M reviewed

View reviewed changes

sdk/src/client/error.rs Outdated Show resolved Hide resolved

kwek20 reviewed

View reviewed changes

sdk/src/types/block/protocol.rs Show resolved Hide resolved

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/slot/epoch.rs Show resolved Hide resolved

kwek20 mentioned this pull request

Add GET /api/core/v3/validators routes #1080

Merged

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/slot/epoch.rs Show resolved Hide resolved


          Update sdk/src/types/block/slot/epoch.rs

3668f72

Co-authored-by: Thoralf-M <[email protected]>

DaughterOfMars dismissed stale reviews from thibault-martinez and abdulmth via

3668f72

August 25, 2023 12:28

Alex Coats added 2 commits

August 25, 2023 09:05


          Revert "Update sdk/src/types/block/slot/epoch.rs"

2beba6b

This reverts commit 3668f72.


          add another fail condition, a test, and remove TODOs

5532ffb

Thoralf-M reviewed

View reviewed changes

sdk/src/types/api/core/response.rs Outdated Show resolved Hide resolved


          Updates and add example comments

6611c69

thibault-martinez previously approved these changes

View reviewed changes

abdulmth previously approved these changes

View reviewed changes


          Updates from TIP

e8bd69f

DaughterOfMars dismissed stale reviews from abdulmth and thibault-martinez via

e8bd69f

August 25, 2023 14:42

DaughterOfMars commented

View reviewed changes

sdk/src/types/block/protocol.rs Show resolved Hide resolved

Thoralf-M previously approved these changes

View reviewed changes


          doc comments

18c2236

DaughterOfMars dismissed Thoralf-M’s stale review via

18c2236

August 25, 2023 15:03

Thoralf-M reviewed

View reviewed changes

sdk/src/types/block/protocol.rs Outdated Show resolved Hide resolved

thibault-martinez requested changes

View reviewed changes

Member

thibault-martinez left a comment

CI failing

Alex Coats added 2 commits

August 25, 2023 11:50


          fix test and comment

3da8e7f


          fix other test

24d04e1

thibault-martinez approved these changes

View reviewed changes

abdulmth approved these changes

View reviewed changes

kwek20 approved these changes

View reviewed changes

Thoralf-M approved these changes

View reviewed changes

DaughterOfMars merged commit 51087bf into 2.0

16 of 18 checks passed

DaughterOfMars deleted the feat/info-response branch

August 25, 2023 16:48

thibault-martinez mentioned this pull request

Update InfoResponse - rust #1015

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Thoralf-M Thoralf-M approved these changes

abdulmth abdulmth approved these changes

thibault-martinez thibault-martinez approved these changes

kwek20 kwek20 approved these changes

qrayven Awaiting requested review from qrayven

Labels

None yet