Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update naming #1032

Merged
merged 9 commits into from
Aug 17, 2023
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Aug 17, 2023

Description of change

The naming of prepareVotingPower() isn't consistent with prepareDecreaseVotingPower() & the method called through the bindings . I deprecated the previous function and added prepareIncreaseVotingPower()

Links to any relevant issues

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Tuditi Tuditi marked this pull request as ready for review August 17, 2023 13:10
Tuditi and others added 3 commits August 17, 2023 15:32
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
@thibault-martinez thibault-martinez merged commit aa97248 into iotaledger:develop Aug 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants