Fix serde feature gating in types #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2023 15:22
added 2 commits
August 25, 2023 08:34
thibault-martinez
approved these changes
Aug 25, 2023
I don't think so |
thibault-martinez
approved these changes
Aug 25, 2023
Thoralf-M
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR fixes compilation without the
serdefeature. Part of the change is to feature gate all API types withserdebecause I don't think they are useful without it anyway. This isn't breaking because everything that was available with the feature enabled is untouched, and without the feature it would not compile.Type of change
Choose a type of change, and delete any options that are not relevant.