Properly handle possibly null protocol params #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
approved these changes
Aug 28, 2023
thibault-martinez
pushed a commit
that referenced
this pull request
Aug 29, 2023
* Add db from 37edd0706ee003a0d17c7da19ba974b17b365cfe * Properly handle possibly null protocol params (#1090) * Fix migration 3 * changelog * Update sdk/tests/wallet/wallet_storage.rs * Nodejs bindings changelog and version bump --------- Co-authored-by: Alexandcoats <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This fixes a problem where the migrations assume that the protocol params exist on the client options.
Links to any relevant issues
Closes #1089
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
New test
check_existing_db_5with missing params.