Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle possibly null protocol params #1090

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

DaughterOfMars
Copy link

Description of change

This fixes a problem where the migrations assume that the protocol params exist on the client options.

Links to any relevant issues

Closes #1089

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

New test check_existing_db_5 with missing params.

@Thoralf-M Thoralf-M merged commit 08a7875 into check_existing_db_5 Aug 28, 2023
@Thoralf-M Thoralf-M deleted the fix/migrate-missing-params branch August 28, 2023 13:50
thibault-martinez pushed a commit that referenced this pull request Aug 29, 2023
* Add db from 37edd0706ee003a0d17c7da19ba974b17b365cfe

* Properly handle possibly null protocol params (#1090)

* Fix migration 3

* changelog

* Update sdk/tests/wallet/wallet_storage.rs

* Nodejs bindings changelog and version bump

---------

Co-authored-by: Alexandcoats <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants