Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db migration: Properly handle possibly null protocol params #1091

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

Thoralf-M
Copy link
Member

Description of change

Db migration: Properly handle possibly null protocol params

Links to any relevant issues

#1089

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Added test

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@DaughterOfMars DaughterOfMars marked this pull request as ready for review August 28, 2023 15:30
@DaughterOfMars DaughterOfMars linked an issue Aug 28, 2023 that may be closed by this pull request
@thibault-martinez thibault-martinez merged commit 81ec43f into develop Aug 29, 2023
23 of 24 checks passed
@thibault-martinez thibault-martinez deleted the check_existing_db_5 branch August 29, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB Migrating to version 1 fails
4 participants