Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodejs send wrapper methods #1103

Merged
merged 8 commits into from
Aug 30, 2023

Conversation

Thoralf-M
Copy link
Member

Description of change

Add send wrapper methods so it's easier for users

Links to any relevant issues

Does the nodejs binding part for #544, Python will be done in another PR

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running an example

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez thibault-martinez changed the title Add send wrapper methods Add nodejs send wrapper methods Aug 30, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

abdulmth
abdulmth previously approved these changes Aug 30, 2023
@Thoralf-M Thoralf-M merged commit 72f19a3 into iotaledger:1.1 Aug 30, 2023
11 checks passed
@Thoralf-M Thoralf-M deleted the nodejs-send-wrapper-methods branch August 30, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants