Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update private tangle setup #1106

Merged
merged 9 commits into from
Sep 5, 2023
Merged

Update private tangle setup #1106

merged 9 commits into from
Sep 5, 2023

Conversation

Thoralf-M
Copy link
Member

@Thoralf-M Thoralf-M commented Aug 30, 2023 •
edited by thibault-martinez
Loading

Description of change

Update private tangle setup to 2.0

Links to any relevant issues

Closes #1096

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Checked in the CI, but currently still fails at nodeinfo calls because iota-core returns wrong data (timestamps are serialized wrong)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@Thoralf-M Thoralf-M marked this pull request as ready for review September 4, 2023 13:45
@Thoralf-M Thoralf-M linked an issue Sep 5, 2023 that may be closed by this pull request
Setup CI private tangle #1096
Closed
@thibault-martinez thibault-martinez merged commit a829d06 into iotaledger:2.0 Sep 5, 2023
20 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Sep 5, 2023
Closed
@Thoralf-M Thoralf-M deleted the 2.0-private-tangle branch September 5, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 approved these changes

@abdulmth abdulmth abdulmth approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup CI private tangle
5 participants
@Thoralf-M @kwek20 @thibault-martinez @abdulmth @Alex6323