Add a worker pool to the client to limit parallel requests #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 30, 2023 15:00
Thoralf-M
reviewed
Aug 31, 2023
Thoralf-M
reviewed
Aug 31, 2023
Thoralf-M
approved these changes
Sep 1, 2023
kwek20
reviewed
Sep 3, 2023
| self.worker_pool | ||
| .process_task(priority, async move { f(client).await }) | ||
| .await | ||
| .unwrap() // TODO |
| types::block::{parent::Parents, payload::Payload, Block, BlockBuilder, Error as BlockError}, | ||
| }; | ||
|
|
||
| impl ClientInner { | ||
| impl Client { |
There was a problem hiding this comment.
Just making sure, this is not breaking in any way since Client derefs to ClientInner, right?
There was a problem hiding this comment.
But wait, ClientInner is public, so this is breaking change?
There was a problem hiding this comment.
Mmmm, yes I suppose so. Technically. But if you used the client this way you probably deserve to have your code break 😆
There was a problem hiding this comment.
It this change (Client/ClientInner) really required for this PR? Otherwise we just do it in 2.0
There was a problem hiding this comment.
Unfortunately it is most definitely required
There was a problem hiding this comment.
I will think about alternative impls though. I'm not 100% with this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR adds a pool of workers (tasks) that accept futures, poll them, and return the result. The worker pool forms a least-recently-used cache and each worker holds a priority queue which is processed synchronously in order.
Outstanding Questions
Links to any relevant issues
#1100
Type of change
Choose a type of change, and delete any options that are not relevant.