-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IRC27 and IRC30 metadata utilities #1160
Conversation
The test probably fails because the new metadata is smaller and then there is not enough amount for a remainder output and the amount requirement is just checked before. I would just revert the changes in this test. Would be nice to have the examples make use of the new types, for example in https://github.com/iotaledger/iota-sdk/blob/develop/sdk/examples/how_tos/native_tokens/create.rs#L68 and
Also bindings are not updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clippy
Description of change
This PR adds two kinds of NFT Immutable Metadata schemas. These can be created and used directly as a
MetadataFeature
in the immutable features of an NFT.Links to any relevant issues
Closes #504
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
I added tests for serialization, and used the metadata in a separate NFT test. However, there is an issue with that test. The input selection returns an
Err(InsufficientAmount { found: 302000, required: 490500 })
when it should returnUnfulfillableRequirement
.