Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of value property in CustomAddress (Node.js) #1171

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Fix type of value property in CustomAddress (Node.js) #1171

merged 2 commits into from
Sep 7, 2023

Conversation

abdulmth
Copy link
Contributor

@abdulmth abdulmth commented Sep 7, 2023

fixes #1060

After this change CustomAddress matches the rust side which is also used in TransactionOptionsDto

DaughterOfMars
DaughterOfMars previously approved these changes Sep 7, 2023
View reviewed changes
thibault-martinez
thibault-martinez requested changes Sep 7, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

@thibault-martinez thibault-martinez merged commit 735dac6 into iotaledger:develop Sep 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Modify type of CustomAddress value in nodejs
4 participants
@abdulmth @thibault-martinez @DaughterOfMars @Thoralf-M