Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IRC metadata in examples #1180

Merged
merged 9 commits into from
Sep 8, 2023
Merged

Use IRC metadata in examples #1180

merged 9 commits into from
Sep 8, 2023

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Sep 7, 2023 •
edited
Loading

Description of change

Uses the Irc27Metadata and Irc30Metadata in some examples.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

thibault-martinez
thibault-martinez requested changes Sep 8, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no Changelog entry in the original PR, please add them here

abdulmth
abdulmth approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know to how extend IPFS is used for NFTs but maybe using ipfs.io in the URI isn't the best practice? idk

@thibault-martinez thibault-martinez merged commit c3c0cf8 into 1.1 Sep 8, 2023
24 checks passed
@thibault-martinez thibault-martinez deleted the feat/irc-examples branch September 8, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex6323 Alex6323 Alex6323 approved these changes

@abdulmth abdulmth abdulmth approved these changes

@kwek20 kwek20 kwek20 approved these changes

@thibault-martinez thibault-martinez Awaiting requested review from thibault-martinez

@Thoralf-M Thoralf-M Awaiting requested review from Thoralf-M

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DaughterOfMars @kwek20 @thibault-martinez @abdulmth @Alex6323 @Thoralf-M