-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cli restore in existing wallet folder #1187
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
previously approved these changes
Sep 11, 2023
1 task
DaughterOfMars
previously approved these changes
Sep 18, 2023
thibault-martinez
requested changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog
Alex6323
reviewed
Sep 20, 2023
Alex6323
reviewed
Sep 20, 2023
kwek20
dismissed stale reviews from Thoralf-M and DaughterOfMars
via
September 20, 2023 13:41
1c50876
DaughterOfMars
previously approved these changes
Sep 20, 2023
Thoralf-M
previously approved these changes
Sep 20, 2023
Thoralf-M
previously approved these changes
Sep 21, 2023
abdulmth
previously approved these changes
Sep 21, 2023
Thoralf-M
previously approved these changes
Sep 21, 2023
abdulmth
previously approved these changes
Sep 22, 2023
thibault-martinez
approved these changes
Sep 22, 2023
abdulmth
approved these changes
Sep 22, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Checks before restoring a stronghold file if there is an existing stronghold.
The check for restoring when accounts exist was already in place, with error: "can't restore backup when there are already accounts"
Also adds a check for
snapshot_path
being a file, not folder (it crashes oddly if you send a folder path)Links to any relevant issues
Closes #1068
Type of change
How the change has been tested
Ran the following scenarios:
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.