Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validationBlocksPerSlot to ProtocolParameters #1189

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Add validationBlocksPerSlot to ProtocolParameters #1189

merged 3 commits into from
Sep 11, 2023

Conversation

thibault-martinez
Copy link
Member

Closes #1188

Thoralf-M
Thoralf-M previously approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@Thoralf-M Thoralf-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also want to update the bindings? If not don't close the issue/create separated ones

@thibault-martinez
Copy link
Member Author

Also want to update the bindings? If not don't close the issue/create separated ones

Much more is missing from the bindings protocol parameters, I created #1134 and #1135 to get up to speed so I think we can close this one.

@thibault-martinez thibault-martinez merged commit e0af5a5 into iotaledger:2.0 Sep 11, 2023
19 of 20 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Sep 11, 2023
Closed
@thibault-martinez thibault-martinez deleted the validation-bps branch September 11, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thoralf-M Thoralf-M Thoralf-M approved these changes

@Alex6323 Alex6323 Alex6323 approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@kwek20 kwek20 kwek20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thibault-martinez @kwek20 @DaughterOfMars @Alex6323 @Thoralf-M