Add a protocol parameters hash test #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still a draft? |
|
Until feat/rent_cost is merged, ye |
DaughterOfMars
force-pushed
the
chore/hash-test
branch
from
5ead880
to
2f1489f
Compare
thibault-martinez
requested changes
Sep 13, 2023
added 3 commits
September 13, 2023 09:32
|
Not sure what to do about CI, should I just disable the failing tests? |
Thoralf-M
previously approved these changes
Sep 14, 2023
thibault-martinez
approved these changes
Sep 15, 2023
Thoralf-M
approved these changes
Sep 15, 2023
Alex6323
approved these changes
Sep 15, 2023
kwek20
approved these changes
Sep 15, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds a test for the protocol parameters using validated data from the TIP.
Links to any relevant issues
Closes #1132
Closes #1124