Dynamic secret manager #1219
Closed
Dynamic secret manager #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 12, 2023 15:51
DaughterOfMars
requested review from
Thoralf-M,
Alex6323 and
thibault-martinez
added 10 commits
October 2, 2023 15:37
Thoralf-M
reviewed
Oct 12, 2023
Thoralf-M
reviewed
Oct 12, 2023
added 12 commits
October 18, 2023 08:48
Alex6323
reviewed
Nov 30, 2023
Comment on lines
+42
to
+61
| // #[cfg(feature = "stronghold")] | ||
| // WalletMethod::ChangeStrongholdPassword { | ||
| // current_password, | ||
| // new_password, | ||
| // } => { | ||
| // wallet | ||
| // .change_stronghold_password(current_password, new_password) | ||
| // .await?; | ||
| // Response::Ok | ||
| // } | ||
| // #[cfg(feature = "stronghold")] | ||
| // WalletMethod::ClearStrongholdPassword => { | ||
| // wallet.clear_stronghold_password().await?; | ||
| // Response::Ok | ||
| // } | ||
| // #[cfg(feature = "stronghold")] | ||
| // WalletMethod::IsStrongholdPasswordAvailable => { | ||
| // let is_available = wallet.is_stronghold_password_available().await?; | ||
| // Response::Bool(is_available) | ||
| // } |
There was a problem hiding this comment.
Is that still a todo for this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR replaces the generic secret manager bounds with trait objects. This helps to clean up a lot of the code, but it also required pretty significant changes to some functionality.
In particular, the wallet builder
finishmethod no longer loads data from the storage. Instead, there is aload_storagefn that will do this part optionally. The reason for this is that otherwise the secret manager type would need to be specified infinisheven when no loading is needed or wanted.