Add feature sets CI

.github/workflows/bindings-nodejs.yml

@@ -2,7 +2,7 @@ name: Nodejs bindings checks
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files
@@ -15,7 +15,7 @@ on:
       - "bindings/nodejs/**"
       - ".github/workflows/bindings-nodejs.yml"
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files

.github/workflows/bindings-python.yml

@@ -2,7 +2,7 @@ name: Python bindings checks
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files
@@ -15,7 +15,7 @@ on:
       - "bindings/python/**"
       - ".github/workflows/bindings-python.yml"
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files
@@ -120,4 +120,3 @@ jobs:
       - name: Run tests
         working-directory: bindings/python
         run: tox
-

.github/workflows/bindings-wallet-nodejs.yml

@@ -2,7 +2,7 @@ name: Nodejs bindings checks (wallet)
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files
@@ -16,7 +16,7 @@ on:
       - ".github/workflows/bindings-wallet-nodejs.yml"
       - ".patches/*"
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files

.github/workflows/bindings-wasm.yml

@@ -1,7 +1,7 @@
 name: Wasm bindings checks
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files
@@ -15,7 +15,7 @@ on:
       - "bindings/nodejs/**"
       - ".github/workflows/bindings-wasm.yml"
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".github/actions/**"
       - "**.rs" # Include all rust files

.github/workflows/build-and-test.yml

@@ -2,7 +2,7 @@ name: Build and Run Tests
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/build-and-test.yml"
@@ -12,7 +12,7 @@ on:
       - "**Cargo.lock" # Include all Cargo.lock files
       - "!**/bindings/**" # Exclude all bindings
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/build-and-test.yml"

.github/workflows/common-features.yml

@@ -0,0 +1,66 @@
+name: Common Feature Sets
+on:
+  push:
+    branches: [develop, production, "1.1"]
+    paths:
+      - ".cargo/config.toml"
+      - ".github/workflows/common-features.yml"
+      - ".github/actions/**"
+      - "**.rs" # Include all rust files
+      - "**Cargo.toml" # Include all Cargo.toml files
+      - "**Cargo.lock" # Include all Cargo.lock files
+      - "!**/bindings/**" # Exclude all bindings
+  pull_request:
+    branches: [develop, production, "1.1"]
+    paths:
+      - ".cargo/config.toml"
+      - ".github/workflows/common-features.yml"
+      - ".github/actions/**"
+      - "**.rs" # Include all rust files
+      - "**Cargo.toml" # Include all Cargo.toml files
+      - "**Cargo.lock" # Include all Cargo.lock files
+      - "!**/bindings/**" # Exclude all bindings
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  CARGO_INCREMENTAL: 0
+
+jobs:
+  common-sets:
+    name: Check common feature sets
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        set:
+          - pow
+          - irc_27
+          - irc_30
+          - client,private_key_secret_manager
+          - client,mqtt
+          - client,participation
+          - wallet,storage
+          - wallet,stronghold
+          - wallet,rocksdb
+          - wallet,participation
+          - wallet,events
+          - wallet,events,ledger_nano
+
+    steps:
+      - name: Checkout the Source Code
+        uses: actions/checkout@v3
+
+      - name: Set up Rust
+        uses: ./.github/actions/setup-rust
+
+      # Required for ledger-nano
+      - name: Install required packages (Ubuntu)
+        run: |
+          sudo apt-get update
+          sudo apt-get install libudev-dev libusb-1.0-0-dev
+
+      - name: Check features [ ${{ matrix.set }} ]
+        run: cargo check --no-default-features -p iota-sdk -F ${{ matrix.set }}

.github/workflows/coverage.yml

@@ -2,7 +2,7 @@ name: Test coverage
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/coverage.yml"

.github/workflows/lint.yml

@@ -1,7 +1,7 @@
 name: Linting
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/lint.yml"
@@ -11,7 +11,7 @@ on:
       - "**Cargo.lock" # Include all Cargo.lock files
       - "!**/bindings/**" # Exclude all bindings
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/lint.yml"

.github/workflows/private-tangle-tests.yml

@@ -2,7 +2,7 @@ name: Build and run specific tests on a private tangle
 
 on:
   push:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/private-tangle-tests.yml"
@@ -14,7 +14,7 @@ on:
       - "**Cargo.lock"
       - "!cli/**" # Exclude CLI
   pull_request:
-    branches: [develop, production, 1.1]
+    branches: [develop, production, "1.1"]
     paths:
       - ".cargo/config.toml"
       - ".github/workflows/private-tangle-tests.yml"

bindings/core/Cargo.toml

@@ -30,6 +30,9 @@ serde = { version = "1.0.188", default-features = false }
 serde_json = { version = "1.0.107", default-features = false }
 thiserror = { version = "1.0.48", default-features = false }
 tokio = { version = "1.32.0", default-features = false }
+url = { version = "2.4.1", default-features = false, features = [
+    "serde",
+] }
 zeroize = { version = "1.6.0", default-features = false }
 
 [features]

bindings/core/src/message_interface_old/message.rs

@@ -14,9 +14,9 @@ use iota_sdk::{
         account::{types::AccountIdentifier, SyncOptions},
         ClientOptions,
     },
-    Url,
 };
 use serde::{Deserialize, Serialize};
+use url::Url;
 
 use super::account_method::AccountMethod;
 

bindings/core/src/method/wallet.rs

@@ -17,9 +17,9 @@ use iota_sdk::{
         },
         ClientOptions,
     },
-    Url,
 };
 use serde::{Deserialize, Serialize};
+use url::Url;
 
 use crate::method::account::AccountMethod;
 #[cfg(feature = "stronghold")]

sdk/Cargo.toml

@@ -141,20 +141,19 @@ tokio = { version = "1.32.0", default-features = false, features = [
 default = ["client", "wallet", "tls"]
 
 events = []
-irc_27 = ["url", "serde"]
-irc_30 = ["url", "serde"]
-ledger_nano = ["iota-ledger-nano"]
-mqtt = ["std", "regex", "rumqttc", "dep:once_cell"]
+irc_27 = ["serde", "dep:url"]
+irc_30 = ["serde", "dep:url"]
+ledger_nano = ["dep:iota-ledger-nano"]
+mqtt = ["std", "tls", "dep:regex", "dep:rumqttc", "dep:once_cell"]
 participation = ["storage"]
-pow = ["std", "num_cpus", "iota-crypto/curl-p"]
-rand = ["dep:rand"]
-rocksdb = ["dep:rocksdb", "storage"]
+pow = ["std", "iota-crypto/curl-p", "dep:num_cpus"]
+rocksdb = ["storage", "dep:rocksdb"]
 serde = [
-    "serde_repr",
     "hashbrown/serde",
     "packable/serde",
     "primitive-types/serde_no_std",
     "zeroize?/serde",
+    "dep:serde_repr",
 ]
 std = [
     "packable/std",
@@ -177,34 +176,34 @@ storage = [
     "dep:heck",
 ]
 stronghold = [
-    "iota_stronghold",
     "iota-crypto/chacha",
+    "dep:iota_stronghold",
     "dep:time",
     "dep:anymap",
     "dep:once_cell",
     "dep:heck",
 ]
 tls = ["reqwest?/rustls-tls", "rumqttc?/use-rustls"]
-private_key_secret_manager = ["bs58"]
+private_key_secret_manager = ["dep:bs58"]
 
 client = [
     "pow",
-    "tokio",
-    "zeroize",
-    "url",
-    "reqwest",
-    "async-trait",
-    "log",
-    "thiserror",
-    "futures",
     "serde",
-    "instant",
     "iota-crypto/bip39",
     "iota-crypto/bip39-en",
     "iota-crypto/slip10",
     "iota-crypto/keccak",
     "iota-crypto/bip44",
     "iota-crypto/random",
+    "dep:thiserror",
+    "dep:futures",
+    "dep:instant",
+    "dep:tokio",
+    "dep:zeroize",
+    "dep:url",
+    "dep:reqwest",
+    "dep:async-trait",
+    "dep:log",
 ]
 wallet = ["client"]
 

sdk/examples/wallet/participation.rs

@@ -19,8 +19,9 @@
 use iota_sdk::{
     client::node_manager::node::Node,
     wallet::{account::types::participation::ParticipationEventRegistrationOptions, Result},
-    Url, Wallet,
+    Wallet,
 };
+use url::Url;
 
 // The node that runs the participation plugin
 const PARTICPATION_NODE_URL: &str = "https://api.testnet.shimmer.network";

sdk/src/client/core.rs

@@ -207,4 +207,10 @@ impl ClientInner {
         };
         Ok(())
     }
+
+    /// Resize the client's request pool
+    #[cfg(not(target_family = "wasm"))]
+    pub async fn resize_request_pool(&self, new_size: usize) {
+        self.request_pool.resize(new_size).await;
+    }
 }

sdk/src/client/node_manager/node.rs

@@ -4,8 +4,7 @@
 use std::hash::Hash;
 
 use serde::{Deserialize, Serialize};
-
-use crate::Url;
+use url::Url;
 
 /// Node authentication object.
 #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, Hash)]

sdk/src/lib.rs

@@ -30,8 +30,6 @@ pub mod utils;
 pub use crypto;
 pub use packable;
 pub use primitive_types::U256;
-#[cfg(feature = "url")]
-pub use url::Url;
 
 #[cfg(feature = "wallet")]
 pub type Wallet = self::wallet::Wallet<client::secret::SecretManager>;

sdk/src/utils/mod.rs

@@ -4,7 +4,7 @@
 #[cfg(feature = "serde")]
 pub mod serde;
 
-#[cfg(feature = "instant")]
+#[cfg(feature = "client")]
 pub fn unix_timestamp_now() -> core::time::Duration {
     instant::SystemTime::now()
         .duration_since(instant::SystemTime::UNIX_EPOCH)

sdk/src/wallet/core/operations/client.rs

@@ -3,6 +3,8 @@
 
 use std::collections::{HashMap, HashSet};
 
+use url::Url;
+
 use super::storage::SaveLoadWallet;
 use crate::{
     client::{
@@ -14,7 +16,6 @@ use crate::{
         Client, ClientBuilder,
     },
     wallet::{Wallet, WalletBuilder},
-    Url,
 };
 
 impl<S: 'static + SecretManage> Wallet<S> {