Add BlockHeader and replace protocol params with id in wrapper
#1264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Sep 19, 2023
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
…/iota-sdk into feat/wrapper-refactor
Thoralf-M
previously approved these changes
Sep 19, 2023
thibault-martinez
previously approved these changes
Sep 19, 2023
This was
linked to
issues
Sep 19, 2023
Closed
DaughterOfMars
dismissed stale reviews from thibault-martinez and Thoralf-M
via
98248a6
thibault-martinez
approved these changes
Sep 19, 2023
Thoralf-M
approved these changes
Sep 20, 2023
Alex6323
approved these changes
Sep 20, 2023
abdulmth
approved these changes
Sep 20, 2023
This was referenced Sep 20, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds the
BlockHeadertype and replaces the protocol parameters stored in the wrapper with the pre-calculated block id.Links to any relevant issues