Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't return error with custom remainder address and ledger nano #1272

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

Thoralf-M
Copy link
Member

Description of change

Don't return error with custom remainder address and ledger nano

Links to any relevant issues

Fixes #1099

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running the simple transaction example modified with ledger nano

        const response = await account.send(amount, address, {
            remainderValueStrategy: {
                strategy: 'CustomAddress',
                value: {
                    address: 'rms1qqdnv60ryxynaeyu8paq3lp9rkll7d7d92vpumz88fdj4l0pn5mruskth6z', 
                    keyIndex: 0, 
                    internal: false, 
                    used: false
                }
            }
        });

DaughterOfMars
DaughterOfMars previously approved these changes Sep 20, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict

@thibault-martinez thibault-martinez merged commit 5ac334d into iotaledger:develop Sep 25, 2023
23 checks passed
@Thoralf-M Thoralf-M deleted the ledger-nano-remainder branch September 25, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to provide remainder Bip44 to ledger nano
4 participants