-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't return error with custom remainder address and ledger nano #1272
Merged
thibault-martinez
merged 5 commits into
iotaledger:develop
from
Thoralf-M:ledger-nano-remainder
Sep 25, 2023
Merged
Don't return error with custom remainder address and ledger nano #1272
thibault-martinez
merged 5 commits into
iotaledger:develop
from
Thoralf-M:ledger-nano-remainder
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/src/client/api/block_builder/input_selection/core/remainder.rs
Outdated
Show resolved
Hide resolved
DaughterOfMars
previously approved these changes
Sep 20, 2023
sdk/src/client/api/block_builder/input_selection/core/remainder.rs
Outdated
Show resolved
Hide resolved
Thoralf-M
commented
Sep 25, 2023
sdk/src/client/api/block_builder/input_selection/core/remainder.rs
Outdated
Show resolved
Hide resolved
sdk/src/client/api/block_builder/input_selection/core/remainder.rs
Outdated
Show resolved
Hide resolved
thibault-martinez
previously approved these changes
Sep 25, 2023
thibault-martinez
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflict
Thoralf-M
force-pushed
the
ledger-nano-remainder
branch
from
September 25, 2023 11:49
590aa81
to
07b2d00
Compare
thibault-martinez
previously approved these changes
Sep 25, 2023
thibault-martinez
approved these changes
Sep 25, 2023
kwek20
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Don't return error with custom remainder address and ledger nano
Links to any relevant issues
Fixes #1099
Type of change
How the change has been tested
Running the simple transaction example modified with ledger nano