Python fix union deserialization #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwek20
reviewed
Sep 27, 2023
kwek20
reviewed
Sep 27, 2023
Thoralf-M
commented
Sep 27, 2023
kwek20
previously approved these changes
Sep 28, 2023
DaughterOfMars
previously approved these changes
Sep 28, 2023
Thoralf-M
force-pushed
the
python-fix-union-deserialization
branch
from
b07fb4a
to
14d352b
Compare
Thoralf-M
commented
Oct 2, 2023
thibault-martinez
previously approved these changes
Oct 2, 2023
kwek20
previously approved these changes
Oct 2, 2023
Thoralf-M
dismissed stale reviews from kwek20 and thibault-martinez
via
fdf4eec
thibault-martinez
approved these changes
Oct 2, 2023
DaughterOfMars
approved these changes
Oct 2, 2023
Alex6323
approved these changes
Oct 2, 2023
kwek20
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Python fix union deserialization by using a custom decoder with the type field
Links to any relevant issues
Fixes #1164
Type of change
How the change has been tested
Running the outputs tests