-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and use Epoch- and SlotIndex #1347
Merged
thibault-martinez
merged 4 commits into
iotaledger:2.0
from
Thoralf-M:python-slot-epoch-index
Sep 29, 2023
Merged
Add and use Epoch- and SlotIndex #1347
thibault-martinez
merged 4 commits into
iotaledger:2.0
from
Thoralf-M:python-slot-epoch-index
Sep 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
previously approved these changes
Sep 28, 2023
DaughterOfMars
previously approved these changes
Sep 28, 2023
DaughterOfMars
previously approved these changes
Sep 28, 2023
thibault-martinez
approved these changes
Sep 28, 2023
DaughterOfMars
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not super happy about ditching the types but whatever
Alex6323
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add and use Epoch- and SlotIndex
Removed one
staking_unbonding_period
because it was duplicated, also putsubunit
at last position, because optional values needs to be lastLinks to any relevant issues
Closes #1191