EVM howtos for L1 -> L2 in js/ts #1383
Conversation
Co-authored-by: Thoralf-M <[email protected]>
bindings/nodejs/examples/how_tos/evm/send_native_token_to_evm.ts
Outdated
Show resolved
Hide resolved
bindings/nodejs/examples/how_tos/evm/send_native_token_to_evm.ts
Outdated
Show resolved
Hide resolved
bindings/nodejs/examples/how_tos/evm/send_native_token_to_evm.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Many things aren't even called in the examples, why are they here?
There was a problem hiding this comment.
The entire file was in evm-toolkit. Thought can move it all inside sdk sometime rust side once we've a helper function of sorts for this later.
This is just temporary till then for ref.
There was a problem hiding this comment.
I think we don't want to put EVM stuff into the SDK itself, apart from address generation and signing for stronghold, this can be done with separated libraries
Would still remove everything that's not actually required and for reference just put a link to the source where you copied at the top
There was a problem hiding this comment.
I agree, we should have the strictly required minimum in the SDK regarding EVM
There was a problem hiding this comment.
So, should the separate library be something like @iota/evm-sdk or should it be a separate external library maintained by community or something?
There was a problem hiding this comment.
Whatever new library is created or added to sdk itself, will then be used both in evm-toolkit and in firefly later.
There was a problem hiding this comment.
What do you mean it's a standalone code ? That it's not published ?
There was a problem hiding this comment.
No, I mean it's live but it's not part of any library as such.
There was a problem hiding this comment.
As discussed on Slack, it looks like we won't be adding EVM-related stuff in the SDK. Let's close this PR and when you have a place where to add them, we'll probably also move the already existing examples there.
There was a problem hiding this comment.
Sounds good. Closing it for now.
Description of change
How to guide to send base, native and nft tokens from L1 to L2 in js/ts.
Links to any relevant issues
Part of wiki issue #1155
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Ran each example.
Running examples are added in each file.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.