Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): output selector #1419

Merged

Conversation

Alex6323
Copy link
Contributor

@Alex6323 Alex6323 commented Oct 11, 2023

Description of change

Changes the output command to expect an OutputSelector which allows to select an output in the account/wallet by providing either the corresponding output id or its index in the list of all account/wallet outputs. It works just like the TransactionSelector we already have.

Links to any relevant issues

Closes #1319

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Not (yet)

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog

cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: DaughterOfMars <[email protected]>
@Alex6323
Copy link
Contributor Author

Alex6323 commented Oct 17, 2023

If you still have some time you can fix if you want. Thx

cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
Alex6323 and others added 2 commits October 18, 2023 10:29
Co-authored-by: Thibault Martinez <[email protected]>
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez merged commit 6dcd242 into iotaledger:develop Oct 18, 2023
20 checks passed
@Alex6323 Alex6323 deleted the feat/cli/output-selector-2 branch October 18, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: add OutputSelector for the output command
4 participants