Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegation to balance #1456

Merged

Conversation

Alex6323
Copy link
Contributor

Links to any relevant issues

Closes #1245

@Alex6323 Alex6323 changed the base branch from develop to 2.0 October 18, 2023 09:00
@Alex6323 Alex6323 changed the title feat(types): Add delegation to balance Add delegation to balance Oct 19, 2023
@Alex6323 Alex6323 marked this pull request as ready for review October 27, 2023 12:43
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to actually use it when computing balances

@thibault-martinez thibault-martinez marked this pull request as draft October 29, 2023 17:45
@thibault-martinez
Copy link
Member

Any news on this?

@Alex6323 Alex6323 marked this pull request as ready for review November 6, 2023 23:27
Thoralf-M
Thoralf-M previously approved these changes Nov 7, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Nov 7, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd update the bindings as well since the change is super small

@Thoralf-M Thoralf-M dismissed stale reviews from DaughterOfMars and themself via 1be3a57 November 27, 2023 08:52
@Thoralf-M Thoralf-M force-pushed the feat/types/delegation-in-balance branch from 0acdf28 to 1be3a57 Compare November 27, 2023 08:52
Thoralf-M
Thoralf-M previously approved these changes Nov 27, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Nov 27, 2023
DaughterOfMars
DaughterOfMars previously approved these changes Nov 27, 2023
@thibault-martinez thibault-martinez merged commit e56c6af into iotaledger:2.0 Nov 27, 2023
28 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Delegation output in Balance
4 participants