Rework block signing API #1461
Merged
Rework block signing API #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaughterOfMars
changed the title
Thoralf-M
reviewed
Oct 25, 2023
added 2 commits
October 25, 2023 14:17
This was
linked to
issues
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 25, 2023
Thoralf-M
reviewed
Oct 26, 2023
Thoralf-M
reviewed
Oct 26, 2023
Thoralf-M
reviewed
Oct 26, 2023
Thoralf-M
previously approved these changes
Oct 26, 2023
Thoralf-M
previously approved these changes
Oct 26, 2023
Thoralf-M
previously approved these changes
Oct 26, 2023
kwek20
previously approved these changes
Oct 27, 2023
thibault-martinez
dismissed stale reviews from Thoralf-M and kwek20
via
6305290
Alex6323
previously approved these changes
Oct 27, 2023
thibault-martinez
approved these changes
Oct 27, 2023
kwek20
approved these changes
Oct 27, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Reworks block building and signing as a two-step process using a client then a secret manager. Renames
BlockWrappertoSignedBlockandBlockWrapperBuildertoUnsignedBlock.Links to any relevant issues
#879
#880