Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework block signing API #1461

Merged
merged 25 commits into from
Oct 27, 2023
Merged

Rework block signing API #1461

merged 25 commits into from
Oct 27, 2023

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Oct 18, 2023 •
edited
Loading

Description of change

Reworks block building and signing as a two-step process using a client then a secret manager. Renames BlockWrapper to SignedBlock and BlockWrapperBuilder to UnsignedBlock.

Links to any relevant issues

#879
#880

@DaughterOfMars DaughterOfMars changed the title Add client + secret manager methods Rework block signing API Oct 25, 2023
@DaughterOfMars DaughterOfMars marked this pull request as ready for review October 25, 2023 18:00
This was linked to issues Oct 25, 2023
Add Block signing - python #879
Closed
Add Block signing - nodejs #880
Closed
Thoralf-M
Thoralf-M previously approved these changes Oct 26, 2023
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Oct 26, 2023
View reviewed changes
Thoralf-M
Thoralf-M previously approved these changes Oct 26, 2023
View reviewed changes
kwek20
kwek20 previously approved these changes Oct 27, 2023
View reviewed changes
Alex6323
Alex6323 previously approved these changes Oct 27, 2023
View reviewed changes
@thibault-martinez thibault-martinez merged commit 143cdef into 2.0 Oct 27, 2023
30 of 31 checks passed
@thibault-martinez thibault-martinez deleted the feat/block-signing-api branch October 27, 2023 16:52
This was referenced Oct 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@kwek20 kwek20 kwek20 approved these changes

@Thoralf-M Thoralf-M Thoralf-M left review comments

@Alex6323 Alex6323 Alex6323 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Block signing - nodejs Add Block signing - python
5 participants
@DaughterOfMars @kwek20 @thibault-martinez @Alex6323 @Thoralf-M