Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StateMetadataOutput's constructor not setting the stateMetadata field #1535

Conversation

thibault-martinez
Copy link
Member

No description provided.

@thibault-martinez thibault-martinez merged commit e0d6841 into iotaledger:develop Oct 30, 2023
8 checks passed
@thibault-martinez thibault-martinez deleted the nodejs-alias-state-metadata branch October 30, 2023 11:26
@schierlm
Copy link

schierlm commented Nov 9, 2023

In case you want to complete other fields "forgotten" by other constructors of types (indirectly) referenced by block Payload subclases (as of 1.1.1-WASM), you can check

https://github.com/iota-laboratory/iota-laboratory.github.io/blob/03fd537e0a5d3be7d40b5b6a9657356b87cf4652/block_payload_types.js#L3-L178

for cf: (constructor fields) values:

  • TreasuryTransactionPayload: No exposed constructor at all, but the hidden one has all fields
  • AliasOutput: Misses (after this commit) nativeTokens, features, immutableFeatures
  • BasicOutput: Misses nativeTokens, features
  • FoundryOutput: Misses nativeTokens, features, immutableFeatures
  • MigratedFunds, NativeToken: No exposed constructor at all
  • MilestonePayload: Exposed constructor has no fields at all
  • NftOutput: Misses nativeTokens, features, immutableFeatures

There is no urge to do that from my side, though. My workaround to dynamically tweak creation of those objects by setting the properties manually works fine for now.

// cc: @Thoralf-M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants