Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some checks for capabilities #1551

Merged
merged 20 commits into from
Nov 7, 2023
Merged

Add some checks for capabilities #1551

merged 20 commits into from
Nov 7, 2023

Conversation

DaughterOfMars
Copy link

@DaughterOfMars DaughterOfMars commented Nov 1, 2023

Description of change

  • Trims trailing zeroes in rust when building capabilities
  • Checks for trailing zeroes when deserializing/unpacking
  • Skips empty bytes in rust and bindings

Links to any relevant issues

Closes #1524
Closes #1545

Thoralf-M
Thoralf-M previously approved these changes Nov 1, 2023
Thoralf-M
Thoralf-M previously approved these changes Nov 2, 2023
Thoralf-M
Thoralf-M previously approved these changes Nov 6, 2023
Thoralf-M
Thoralf-M previously approved these changes Nov 6, 2023
tadzik
tadzik previously approved these changes Nov 7, 2023
sdk/src/types/block/error.rs Outdated Show resolved Hide resolved
@thibault-martinez thibault-martinez dismissed stale reviews from tadzik, Thoralf-M, and themself via ccad44b November 7, 2023 08:38
Co-authored-by: Tadeusz Sośnierz <[email protected]>
@thibault-martinez thibault-martinez merged commit da32fad into 2.0 Nov 7, 2023
26 of 30 checks passed
@thibault-martinez thibault-martinez deleted the feat/capabilities branch November 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants